Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.4] set lastnotification time as created time for new bucket level monitor #677

Merged
merged 1 commit into from
Nov 11, 2022
Merged

[Backport 2.4] set lastnotification time as created time for new bucket level monitor #677

merged 1 commit into from
Nov 11, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 817d9ef from #675

@eirsep @github-actions
set lastnotification time as created time for new bucket level monito…
8ed59a4 
…r alert (#675)

Signed-off-by: Surya Sashank Nistala <[email protected]>

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 817d9ef)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team November 11, 2022 02:52
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022 •
edited
Loading

Codecov Report

Merging #677 (817d9ef) into 2.4 (a4a5856) will decrease coverage by 0.00%.
The diff coverage is 69.00%.

❗ Current head 817d9ef differs from pull request most recent head 8ed59a4. Consider uploading reports for the commit 8ed59a4 to get more accurate results

@@             Coverage Diff              @@
##                2.4     #677      +/-   ##
============================================
- Coverage     76.11%   76.11%   -0.01%     
  Complexity      116      116              
============================================
  Files           124      124              
  Lines          6615     6618       +3     
  Branches        981      982       +1     
============================================
+ Hits           5035     5037       +2     
  Misses         1083     1083              
- Partials        497      498       +1
Impacted Files Coverage Δ
...ain/kotlin/org/opensearch/alerting/InputService.kt 94.28% <ø> (ø)
...n/kotlin/org/opensearch/alerting/TriggerService.kt 73.21% <ø> (ø)
...pensearch/alerting/action/ExecuteMonitorRequest.kt 100.00% <ø> (ø)
...ensearch/alerting/action/GetDestinationsRequest.kt 100.00% <ø> (ø)
...nsearch/alerting/action/GetEmailAccountResponse.kt 92.50% <ø> (ø)
...pensearch/alerting/action/GetEmailGroupResponse.kt 92.50% <ø> (ø)
...g/opensearch/alerting/action/GetMonitorResponse.kt 92.50% <ø> (ø)
...pensearch/alerting/model/AlertingConfigAccessor.kt 78.37% <ø> (ø)
...arch/alerting/model/BucketLevelTriggerRunResult.kt 90.00% <ø> (ø)
...nsearch/alerting/model/DocumentExecutionContext.kt 100.00% <ø> (ø)
... and 88 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep eirsep merged commit 5d5195d into 2.4 Nov 11, 2022
@github-actions github-actions bot deleted the backport/backport-675-to-2.4 branch November 11, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amsiglan amsiglan amsiglan approved these changes

@getsaurabh02 getsaurabh02 getsaurabh02 approved these changes

@eirsep eirsep eirsep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @eirsep @getsaurabh02 @amsiglan